[5.5.3]: Fix GRIB IOSP time coords from intervals, for 2-D time datasets

Unidata / netcdf-java

The Unidata netcdf-java library

https://docs.unidata.ucar.edu/netcdf-java/current/userguide/index.html

BSD 3-Clause "New" or "Revised" License

142 stars 69 forks source link

[5.5.3]: Fix GRIB IOSP time coords from intervals, for 2-D time datasets #1248

Closed ethanrd closed 11 months ago

ethanrd commented 11 months ago

Description of Changes

Fix generation of time coordinate variables from time intervals for 2-D time datasets. Ensure resulting time coordinate variables are strictly monotonically increasing. Handle when time intervals are irregular and overlapping.

See issue #1060.

PR Checklist

[x] Link to any issues that the PR addresses
[ ] Add labels
[x] Open as a draft PR until ready for review
[x] Make sure GitHub tests pass
[ ] Mark PR as "Ready for Review"

ethanrd commented 11 months ago

Agree, probably easier to ignore the new test file. Are there other test files excluded from this test?

tdrwenski commented 11 months ago

Agree, probably easier to ignore the new test file. Are there other test files excluded from this test?

Just pushed a fix to ignore that test case!