Intermediate PR: Handle multiple different time and altitude axes for GridAsPoint writer - Githubissues

Unidata / netcdf-java

The Unidata netcdf-java library

https://docs.unidata.ucar.edu/netcdf-java/current/userguide/index.html

BSD 3-Clause "New" or "Revised" License

142 stars 69 forks source link

Intermediate PR: Handle multiple different time and altitude axes for GridAsPoint writer #1250

Closed mnlerman closed 10 months ago

mnlerman commented 11 months ago

This is a good breaking point to submit changes associated with https://github.com/Unidata/tds/issues/269

Tasks completed in this pull request:

Add timeName attribute to DsgFeatureCollection
And altName attribute to DsgFeatureCollection
Add constructors to pass timeName and altName up through the inheritance tree
Assign timeName and altName attributes for
Tests to confirm that altName and timeName are assigned correctly for CoverageAsPoint and CoverageAsProfile
Rework Point writer and StationCollection writer to write the actual axis names rather than generic names

Work still to be completed:

Rework StationProfileCollectionWriter to write the actual axis names rather than generic names
Rework ProfileCollectionWriter to write the actual axis names rather than generic names

PR Checklist

[x] Link to any issues that the PR addresses
[x] Add labels
[x] Open as a draft PR until ready for review
[x] Make sure GitHub tests pass
[x] Mark PR as "Ready for Review"