search

Unidata / netcdf-java

The Unidata netcdf-java library
https://docs.unidata.ucar.edu/netcdf-java/current/userguide/index.html
BSD 3-Clause "New" or "Revised" License
142 stars 69 forks source link

Fix handling of the dap4: protocol. #1255

Closed DennisHeimbigner closed 10 months ago

DennisHeimbigner commented 10 months ago

re: Issue https://github.com/Unidata/netcdf-java/issues/985

Description of Changes

The DAP4 code was improperly handling the use of the "dap4:" protocol in a URL. This PR fixes it by detecting that protocol and doing two actions:

  1. Convert the protocol to "http:".
  2. Add the fragment "#dap4" to end of the URL.

Note that in action 1, this should really be https, but test.opendap.org (a Hyrax server) still accepts only http; one hopes that other servers are setup to redirect http: to https:

PR Checklist