Fixes reading ncml files stored on S3 (Resolves https://github.com/Unidata/netcdf-java/issues/1231). This requires fixing logic used by the NcmlReader to use MFiles instead of Files and URLs. Unfortunately it also requires several special cases, checking for cdms3 protocols-- this isn't the nicest but I am not seeing another way to fix this without refactoring all this code.
Description of Changes
Fixes reading ncml files stored on S3 (Resolves https://github.com/Unidata/netcdf-java/issues/1231). This requires fixing logic used by the NcmlReader to use
MFiles instead ofFiles andURLs. Unfortunately it also requires several special cases, checking forcdms3protocols-- this isn't the nicest but I am not seeing another way to fix this without refactoring all this code.Add unit tests to test the
DatasetURLcode. Integration tests will be added to the TDS (https://github.com/Unidata/tds/pull/438)Jenkins tests passing: https://jenkins-aws.unidata.ucar.edu/view/Users/job/tara-netcdf-java/40/