Unidata / netcdf-java

The Unidata netcdf-java library
https://docs.unidata.ucar.edu/netcdf-java/current/userguide/index.html
BSD 3-Clause "New" or "Revised" License
142 stars 69 forks source link

Revert s3 performance regression that checked if files were ncml by opening them #1281

Closed tdrwenski closed 8 months ago

tdrwenski commented 8 months ago

Revert part of the changes from https://github.com/Unidata/netcdf-java/pull/1277 to fix S3 performance regression. That change made it possible to identify ncml files that had extensions other than "ncml" or "xml" by peaking inside the files. That check will be made for all s3 files and is slow, so it doesn't seem worthwhile-- so this PR reverts that change.