Improve test reliability by checking the actual connections is same as before and after test instead of checking it is 0.
The actualconnections will increase any time a new HTTPConnection is opened, but if this isn't opened with try-with-resources, the connection may not be closed. So if we check if the actualconnections == 0 in our tests, we are testing that everywhere in the tests run before the HTTPConnections have been closed properly, which probably is not always the case.
Description of Changes
Erase this and add a general description of changes, heads-up on any tricky parts, etc., here.
Improve test reliability by checking the actual connections is same as before and after test instead of checking it is 0.
The
actualconnectionswill increase any time a newHTTPConnectionis opened, but if this isn't opened with try-with-resources, the connection may not be closed. So if we check if theactualconnections == 0in our tests, we are testing that everywhere in the tests run before theHTTPConnectionshave been closed properly, which probably is not always the case.Description of Changes
Erase this and add a general description of changes, heads-up on any tricky parts, etc., here.
PR Checklist