search

Unidata / netcdf-java

The Unidata netcdf-java library
https://docs.unidata.ucar.edu/netcdf-java/current/userguide/index.html
BSD 3-Clause "New" or "Revised" License
144 stars 70 forks source link

Rewrite groovy tests as junit #1334

Closed tdrwenski closed 5 months ago

tdrwenski commented 5 months ago

Description of Changes

Closes https://github.com/Unidata/netcdf-java/issues/1188.

  1. Rewrites groovy/spock tests as junit:

    cdm/core/src/test/groovy/ucar/nc2/ft/point/FlattenedDatasetPointCollectionSpec.groovy
cdm/core/src/test/groovy/ucar/nc2/ft/point/PointIteratorFilteredSpec.groovy 
cdm/core/src/test/groovy/ucar/nc2/ft2/coverage/HorizCoordSysCrossSeamBoundarySpec.groovy
cdm/core/src/test/groovy/ucar/nc2/util/cache/ReacquireClosedDatasetSpec.groovy 
netcdf4/src/test/groovy/ucar/nc2/jni/netcdf/Nc4IospMiscSpec.groovy
netcdf4/src/unloadedTest/groovy/ucar/nc2/jni/netcdf/UnloadedNc4IospSpec.groovy

    Note that for Nc4IospMiscSpec.groovy, some private members were being tested so I had to make them package private in order to keep the test as is.

  2. Deletes:

    ./legacy/src/test/groovy/thredds/crawlabledataset/s3/ThreddsS3ClientImplSpec.groovy
./legacy/src/test/groovy/thredds/crawlabledataset/s3/CachingThreddsS3ClientSpec.groovy
./legacy/src/test/groovy/thredds/crawlabledataset/s3/CrawlableDatasetAmazonS3Spec.groovy
./legacy/src/test/groovy/thredds/crawlabledataset/s3/S3URISpec.groovy

    as these are testing legacy code.

  3. Removes all groovy/ Spock dependencies.