Fix and extend Geotiff IFD handling to allow all integer types

Unidata / netcdf-java

The Unidata netcdf-java library

https://docs.unidata.ucar.edu/netcdf-java/current/userguide/index.html

BSD 3-Clause "New" or "Revised" License

144 stars 70 forks source link

Fix and extend Geotiff IFD handling to allow all integer types #1341

Closed WeatherGod closed 5 months ago

WeatherGod commented 5 months ago

Description of Changes

Follows specs from pg. 15-16 of v6.0 TIFF: https://www.itu.int/itudoc/itu-t/com16/tiff-fx/docs/tiff6.pdf
Added roundtrip tests of the private Geotiff method via reflection
This does reveal an existing API flaw that will cause overflow of large unsigned integers

PR Checklist

[ ] Link to any issues that the PR addresses
[ ] Add labels
[ ] Open as a draft PR until ready for review
[ ] Make sure GitHub tests pass
[x] Mark PR as "Ready for Review"

WeatherGod commented 5 months ago

Was talking with a colleague about how I couldn't test private methods, which was needed to properly test out the fixes to read/writeIntValue, when they pointed me to Java reflection, which I never knew about.