Unidata / netcdf-java

The Unidata netcdf-java library
https://docs.unidata.ucar.edu/netcdf-java/current/userguide/index.html
BSD 3-Clause "New" or "Revised" License
143 stars 68 forks source link

NetcdfFiles should use its own logger #1346

Closed rschmunk closed 1 month ago

rschmunk commented 1 month ago

Trying to figure out why I was not getting log messages from NetcdfFiles and found it was using a different class's logger.

PR Checklist

tdrwenski commented 1 month ago

I will ignore that failing test while I investigate it-- I just saw it on my PR yesterday as well, I'm sure it's not related to your changes

rschmunk commented 1 month ago

I wasn't paying a lot of attention, @tdrwenski, but it looked like Github was simply timing out while running tests?

Anyhow, thanks @haileyajohnson for commiting.