Add logger to N3headerNew that CDF5 is not supported

Unidata / netcdf-java

The Unidata netcdf-java library

https://docs.unidata.ucar.edu/netcdf-java/current/userguide/index.html

BSD 3-Clause "New" or "Revised" License

143 stars 68 forks source link

Add logger to N3headerNew that CDF5 is not supported #1350

Closed rschmunk closed 1 month ago

rschmunk commented 1 month ago

Description of Changes

Added a logger.debug statement to N3headerNew to indicate that CDF5/Pnetcdf is not supported yet\ even though the magic number is recognized.

PR Checklist

[x] Link to any issues that the PR addresses
[x] Add labels
[x] Open as a draft PR until ready for review
[x] Make sure GitHub tests pass
[x] Mark PR as "Ready for Review"

rschmunk commented 1 month ago

Maybe this could have been logger.warn, but for what I was working on, logger.debug was sufficient to figure out why a dataset was triggering a "Is it really CDM?" response. Up to you.

Edit: And on further thought, I do wonder if throwing an unsupported-feature exception of some sort might be an even better idea?