search

Unidata / python-gallery

Repository of examples showing off the use of Python for meteorology.
http://unidata.github.io/python-gallery
88 stars 31 forks source link

pyproj link broken GOES-16: True Color notebook #105

Closed julienchastang closed 5 years ago

julienchastang commented 5 years ago

In mapping_GOES16_TrueColor.ipynb the pyproj link is broken. In addition, I wonder if we can eliminate references to pyproj since pyproj is no longer used in this notebook in lieu of cartopy.

ping @blaylockbk

blaylockbk commented 5 years ago

I downloaded a copy of the repo and made some edits

@julienchastang Could you walk me through the process to add these changes? This is my first time contributing to someone's else's repo. I need to make a pull request, right?

julienchastang commented 5 years ago

@blaylockbk actually the markdown tables do render (quite nicely, I think) in the notebooks. See the python-gallery/notebooks folder at https://jupyterhub.unidata.ucar.edu, for example.

blaylockbk commented 5 years ago

I see. I was looking at the webpage here: https://unidata.github.io/python-gallery/examples/mapping_GOES16_TrueColor.html#sphx-glr-examples-mapping-goes16-truecolor-py. It doesn't look like the tables where converted there.

Brian

On Tue, May 7, 2019 at 2:44 PM Julien Chastang notifications@github.com wrote:

@blaylockbk https://github.com/blaylockbk actually the markdown tables do render (quite nicely, I think) in the notebooks. See the python-gallery/notebooks folder at https://jupyterhub.unidata.ucar.edu, for example.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Unidata/python-gallery/issues/105#issuecomment-490248365, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPVZDKVS2VQRTUJSJI7LJLPUHS4TANCNFSM4HKATQOA .

julienchastang commented 5 years ago

Oh right. That I had not noticed. There are also a few other rendering problems. I think the technology here is at fault since the markdown is valid and renders correctly in other contexts. I'll try to dig into this. I also may break apart the issues/tasks i.e., verbiage changes vs rendering problems.