Mslp hi lo map

[kgoebber]

Plotting H and L with MSLP and 100-500 hPa thickness

[CLAassistant]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: kgoebber
:x: Kevin Goebbert

---

Kevin Goebbert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[kgoebber]

Sorry, I meant to put this as a separate branch from master, but I did a branch off of the other example I added last week. Also, new computer so the CLA thing is because of a different name I had in my git config files, all still associated with the same email address so that CLA appears as signed.

[jrleeman]

Looks like flake has caught some things. There is an unrelated data failure on meteogram currently as well.

[kgoebber]

Okay, I've corrected all but one of the flake8 problems. It seems it doesn't like the block quote at the beginning of the definition and I can't seem to squash it.

[dopplershift]

@kgoebber It doesn't like the docstring on plot_maxmin_points because it's using triple single quotes; picky I know, sorry.

[kgoebber]

So it should be triple double quotes?

[dopplershift]

Correct.

[dopplershift]

@kgoebber You should check your git config, these latest commits aren't attached to your account:

git config --get user.name
git config --get user.email

The email is the really important part for linking here.

[kgoebber]

They are correct now (even before last commit), but was not set up prior to the initial commit. Would it be easier to kill this, then I'll save off copy of file, delete branch and resubmit PR with new name?

[dopplershift]

You could fix it by doing a git rebase to squash things together and then a git commit --amend --reset-author. Doing what you described is fine though.