search

Unidata / python-training

Notebooks teaching Python for use meteorology and atmospheric and climate sciences.
https://unidata.github.io/python-training
BSD 3-Clause "New" or "Revised" License
125 stars 69 forks source link

QG Notebook broken #90

Closed dopplershift closed 4 years ago

dopplershift commented 4 years ago

The QG notebook was completely busted by metpy 1.0rc1. Not sure if it's a simple update, or if there's something not-so-good in the rc. (heads up @jthielen )

jthielen commented 4 years ago

I'll have to take a closer look once https://github.com/Unidata/MetPy/pull/1304 / https://github.com/Unidata/MetPy/pull/1325 are in, but my initial guess from a quick read through is that that notebook assumes mpcalc.smooth_n_point outputs pint Quantities when supplied xarray.DataArray, which changed to outputting xarray.DataArray with https://github.com/Unidata/MetPy/pull/1223.

dopplershift commented 4 years ago

That makes sense, I can run with that and see what happens. This is the first time I've tried to use the RC in a workshop, and I did that because some combination of xarray and pint updates broke something in getting the longitude coords.

dopplershift commented 4 years ago

Fixed in 455ffa0.