search

Unidata / thredds

THREDDS Data Server v4.6
https://www.unidata.ucar.edu/software/tds/v4.6/index.html
265 stars 179 forks source link

ToolsUI cleanup #1279

Closed JohnLCaron closed 5 years ago

JohnLCaron commented 5 years ago

Mostly minor fixes from IntelliJ code inspections. Restored FeatureScanOpPanel, with minor fix that was throwing an Exception. Not sure how it got removed, but seems to be a one-off.

rschmunk commented 5 years ago

As many changes as I was making a few months in ToolsUI to break code out into separate classes, stuff may have happened.

JohnLCaron commented 5 years ago

yeah, stuff happens ;^) thanks for your help cleaning it up.

On Thu, May 9, 2019 at 12:19 AM R. Schmunk notifications@github.com wrote:

As many changes as I was making a few months go into ToolsUI to break code out into separate classes, stuff may have happened.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Unidata/thredds/pull/1279#issuecomment-490759288, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEVZQAGYQBJ2NHIU6MGBXLPUO66FANCNFSM4HLWTVKQ .

JohnLCaron commented 5 years ago

Ok, enough ui for now.

rschmunk commented 5 years ago

Just noticing the indenting changes in OpPanel. Is that an IntelliJ thing to have indents be 2 chars rather than 4?

Asking because I discovered in the past that indenting in various classes was 2 chars instead of the 4 that I expected.