Unidata / thredds

THREDDS Data Server v4.6
https://www.unidata.ucar.edu/software/tds/v4.6/index.html
265 stars 179 forks source link

Allow 64-bit dimension lengths #875

Open cwardgar opened 7 years ago

cwardgar commented 7 years ago

From LQO-782179.

The length of a dimension in the CDM is limited to a signed int (32 bits). Presumably, this is to match the dimension length limit in NetCDF-3, which is also a 32-bit int (although it is unsigned, not signed). This limit has been in place at least 10 years, and probably appeared in NetCDF-Java 1.0.

Since then, NetCDF-4 was released, which supports 64-bit unsigned integer dimension lengths. We ought to upgrade the CDM to use type long for dimension lengths, which is a 64-bit signed integer.

cyrilleponcelet commented 7 years ago

Note that in java 8, some support for unsigned long where added to the class java.lang.Long, so we can use long type to be treated as unsigned