search

Unidata / threddsIso

A THREDDS Data Server extension which generates NCML, a metadata rubric, and ISO 19115.
7 stars 17 forks source link

Moving forward #46

Open lesserwhirls opened 4 years ago

lesserwhirls commented 4 years ago

In the process of updating the threddsIsoTds5 branch of this repo to use the latest version of netCDF-Java (and the proposed public API), I noticed a few things that are still not quite right with respect to coming in-line with ncIso. Of course, the transforms being out of sync are still an issue. However, there are a few more things as well. I'd really like to bring this repo up-to-speed, but it's not exactly clear where things stand in general. The initial steps for combining the codebases of ncIso and threddsIso have been done. The next step will be to refactor the layout of this repository to become a maven multi module project, which will allow us to produce a stand-alone ncIso jar cleanly along-side the plugin for the TDS.

So, as a conversation starter - is there still interest to have the two codebases combined and managed in one location?

kevin-obrien commented 4 years ago

Hi Sean, yes - definitely still interest in merging those code bases. I'll add @noaaroland to this thread.

noaaroland commented 4 years ago

Please let me know if there is something you need me to do. Happy to test command-line release candidates.

lesserwhirls commented 4 years ago

PR Unidata/threddsIso#47 has the refactored codebase, although it might be a little easier to see on my branch over at https://github.com/lesserwhirls/threddsIso/tree/refactor. A lot of the code in the https://github.com/NOAA-PMEL/uafnciso/ repository lives in the nciso maven submodule. The TDS plugin code lives in the tds-plugin maven submodule. Those submodules share code contained in the nciso-common submodule, which includes the xsl transforms. I have not made an attempt to reconcile those xslt's (here) with the ones in the NOAA-PMEL repository (here), and that's perhaps one of the most important goals of having a combined codebase, but that will be the next task.

If you'd like to try the command line jar produced by the code in my PR, you can snag it here.

noaaroland commented 4 years ago

I downloaded the jar and it performs as expected on the examples I tried. We will probably do more extensive testing by putting the jar in our regular process for building ISO metadata.

I will note that the CDN links I baked into my code for the software to download the XSLTs have certificate/gateway problems. I struggled with how to provide those files and two attempts to find a good CDN for a github file both failed. I hope you have some better ideas on how to host those file.