search

Unidata / threddsIso

A THREDDS Data Server extension which generates NCML, a metadata rubric, and ISO 19115.
7 stars 17 forks source link

Big refactor #47

Closed lesserwhirls closed 4 years ago

lesserwhirls commented 4 years ago

Split up the single unified codebase into three maven modules - one for the commandline utility, one for the TDS plugin, and one to hold common classes.

In addition, tests have been added, and an initial pass at using github actions for automated testing has been made.

Finally, a few leaky file handle bugs were squashed. Always a win there.

lesserwhirls commented 4 years ago

If anyone would like to check out the command line utility jar associated with this PR, please see here.

This is a pretty big shift, so testing is very much welcome!

lesserwhirls commented 4 years ago

Also, the github action won't run until this is merged. However, there are 16 jobs that are associated with it - basically runs the tests using java 8 and 11 (Zulu JDK as well as AdoptOpenJDK HotSpot) using both the dev and prod maven profiles.

lesserwhirls commented 4 years ago

Yep, that's a good catch! It came from our repo, but we don't actually use it here or over in the TDS, so I've removed it (PR updated).