search

UnifiedPush / common-proxies

Mirror of https://codeberg.org/UnifiedPush/common-proxies
MIT License
24 stars 11 forks source link

Support new FCM API #47

Closed provokateurin closed 3 months ago

p1gp1g commented 2 years ago

What do you mean by new api/legacy api ?

If it is about the "/v2" rewrite proxy for FCM and the previous rewrite proxy, they are both working at this moment :)

provokateurin commented 2 years ago

No I mean this: Screenshot_20220718_125951 I had to enable the legacy API to get the proxy to work.
The new API should be supported and how to use the legacy API should be documented, because it took me a while to figure it out.

karmanyaahm commented 2 years ago

The v1 API is far more complicated, I would have to use the Firebase library. It also requires files and pubkeys instead of just an authentication token. Since there's no deprecation imminent, we should add instructions about the legacy API and revisit upgrading to v1 later.

This issue can be left open till then Will close until other developments. Deferring to UnifiedPush/documentation#67

moffatman commented 7 months ago

Can we re-open this, I got a warning email from google, they are not going to support either the legacy HTTP protocol or server keys after June 20, 2024

karmanyaahm commented 7 months ago

Yikes

karmanyaahm commented 7 months ago

Did it contain any links with more details?

moffatman commented 7 months ago

https://firebase.google.com/docs/cloud-messaging/migrate-v1

moffatman commented 5 months ago

Anyone planning to fix this... approx 3 months until taken down

karmanyaahm commented 5 months ago

I'll put a call out in the UP chat, or I'll try to do it soon if not

moffatman commented 4 months ago

@karmanyaahm I opened a PR, it seems to work for me. But I appreciate some review as this is my first ever Go code

karmanyaahm commented 4 months ago

Thank you so much! I will take a look this week

On Thu, Apr 18, 2024, 20:21 Callum Moffat @.***> wrote:

@karmanyaahm https://github.com/karmanyaahm I opened a PR, it seems to work for me. But I appreciate some review as this is my first ever Go code

— Reply to this email directly, view it on GitHub https://github.com/UnifiedPush/common-proxies/issues/47#issuecomment-2065576886, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHZIPSU3RLADUFLRII2WQTDY6BWTBAVCNFSM53UQ5HP2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBWGU2TONRYHA3A . You are receiving this because you were mentioned.Message ID: @.***>

karmanyaahm commented 4 months ago

reopening to track fixing the things @p1gp1g suggested https://github.com/UnifiedPush/common-proxies/pull/66#issuecomment-2095305345

p1gp1g commented 3 months ago

This is good as it is, the users will notice they need to migrate :+1:

We should release a new version soon cf #67