search

UnifiedPush / common-proxies

Mirror of https://codeberg.org/UnifiedPush/common-proxies
MIT License
24 stars 11 forks source link

Migrate to FCM HTTP v1 API #66

Closed moffatman closed 4 months ago

moffatman commented 4 months ago

The current API is deprecated and will be turned off in June 2024.

Fixes #47

karmanyaahm commented 4 months ago

Hi I'm so sorry for the delay, on first glance it looks pretty good to me, so I'll merge it and then test it a little more myself and then push a release. Thank you SO much for writing this

p1gp1g commented 4 months ago

I was sure I had send my review for this PR and planned to do the changes myself this week if they were not done (which of course was difficult without the review).

The proxy should use the legacy request until rewrite.fcm.credentialsPath/s is set. OR, Since the legacy request will be removed in a very near future, we can check if rewrite.fcm.key/s is present in the config and exit with an error. So users will know they have to update something manually.

It would be nice to have a page to explain how to grap this new token

BTW, maybe this is the moment to remove rewrite.fcm.credentialsPath in favour of rewrite.fcm.credentialsPaths, since this is a non-backward compatible change

p1gp1g commented 3 months ago

It currently fails if credentialPath is not set, so users will notice they have to migrate :+1: