Consider returning a nullable string in getDistributor()

UnifiedPush / flutter-connector

UnifiedPush connector library for flutter

Apache License 2.0

31 stars 9 forks source link

Consider returning a nullable string in getDistributor() #88

Closed emersion closed 1 year ago

emersion commented 1 year ago

Currently the function returns a Future<String>, with a special-case of the empty string meaning "no distributor". This is unidiomatic Dart. It would be nicer to change it to Future<String?>, with null meaning "no distributor".

karmanyaahm commented 1 year ago

@p1gp1g Would this require incrementing the major version?

p1gp1g commented 1 year ago

Yes probably. I can revert the change and keep it in suspend