UnifierHQ / unifier

A fast and versatile Discord bot connecting servers and platforms
https://unifier-wiki.pixels.onl/
GNU Affero General Public License v3.0
7 stars 7 forks source link

Message with invalid global emoji placeholder gets deleted #156

Closed greeeen-dev closed 1 week ago

greeeen-dev commented 1 month ago

Checklist

Describe the bug

When a global emoji is being sent (in the format [emoji: emoji]), Unifier deletes the sent message to replace this placeholder text with the actual emoji. However, if the emoji is invalid, Unifier deletes the message but never sends the formatted text back as a webhook message.

To Reproduce

  1. Send a message in a Unifier room with an invalid emoji name

Expected behavior

Unifier does not delete the message at all.

Screenshots

Platform

Discord

Version

v2.0.6-patch4

Extensions

Revolt Support

Modified instance

Modified instance repository

Additional context

Probably due to a missing emoji name check in the on_message func. Investigating.

greeeen-dev commented 3 weeks ago

Need to test fix for v3 before I publish it to other versions

greeeen-dev commented 3 weeks ago

Works on v3

greeeen-dev commented 3 weeks ago

Will push the bugfix after v3 release

greeeen-dev commented 1 week ago

I actually pushed v2 bugfix already

Will push for v1.2 soon