UnigramDev / Unigram

Telegram for Windows
https://www.microsoft.com/store/apps/9n97zckpd60q
GNU General Public License v3.0
3.8k stars 443 forks source link

Action Center notification not going to source channel #1521

Closed Yuraconst closed 4 years ago

Yuraconst commented 4 years ago

Instead of source channel (such as Unigram-Insiders), it goes to the talk list with nothing opened when clicking a notification within the Action Center sidebar.

MarcAnt01 commented 4 years ago

Do you mean that discussion group gets opened instead of the channel?

Yuraconst commented 4 years ago

no, NOTHING is opened except the app itself - it just stays at the app's list of contacts/channels.

MarcAnt01 commented 4 years ago

no, NOTHING is opened except the app itself - it just stays at the app's list of contacts/channels.

And is this behavior limited to channels with a discussion group?

Yuraconst commented 4 years ago

Any kind of channel - chatroom or news stream - does this if I click a notification while the client software is not currently open.

MarcAnt01 commented 4 years ago

I don't understand

Yuraconst commented 4 years ago

Belarussian news stream that has NO discussion channel attached also does this stuff.

Yuraconst commented 4 years ago

There's no easy way for me to show this bug, sadly. BTW, I'm on Windows 10 Home x64

MarcAnt01 commented 4 years ago

So basically once you click on a notification with the app closed, Unigram doesn't redirect to the channel, right?

Yuraconst commented 4 years ago

Yes, exactly - if the app is closed, it only opens and does nothing else. If it's already open, clicking a notification properly moves to the source channel (chatroom or loudspeaker)

MarcAnt01 commented 4 years ago

Please, try to see if it happens with the app open, too

Yuraconst commented 4 years ago

as I said, if it's open the source channel redirect happens correctly.

MarcAnt01 commented 4 years ago

Ah, so it's related to push notifications

MarcAnt01 commented 4 years ago

@FrayxRulez should I leave that open or move it to push notifications bugs list?

Yuraconst commented 4 years ago

probably move it to "push notification bugs" since Action Center is basically the Push Notification module of Windows 10.

MarcAnt01 commented 4 years ago

probably move it to "push notification bugs" since Action Center is basically the Push Notification module of Windows 10.

No, that's wrong, action centre works for in-app ones, too

Yuraconst commented 4 years ago

Action Center turns all in-app notifs into Push IIRC (tried to send via the gitbot but it's a total squalapeno)

MarcAnt01 commented 4 years ago

No, you confuse toast notifications with push ones

Yuraconst commented 4 years ago

@MarcAnt01 it mixes old and new notifications. Not sure if the "rich" notifs (with icon and/or reply field) are actually toast or push, official Telg uses either its own lib or the Win32 lib (in latter case the notifs are text-only)

MarcAnt01 commented 4 years ago

Toast notifications are the new notifications that appear as heads-ups and in the action centre. They can be push (syncing Telegram servers to Microsoft ones, that doesn't require the app to be open) or in-app (keeping the app open, a new notification is sent from the app)

Yuraconst commented 4 years ago

@MarcAnt01 oh, that makes the qualification of this issue as push or non-push kinda confusing...

MarcAnt01 commented 4 years ago

It's clearly related to push ones, closing

Yuraconst commented 4 years ago

@MarcAnt01 Ah, but maybe keeping the tray agent would have been wiser and avoided this issue by counting the app as open by the tray agent, thus treating notifs as Toast, not Push?

MarcAnt01 commented 4 years ago

@MarcAnt01 Ah, but maybe keeping the tray agent would have been wiser and avoided this issue by counting the app as open by the tray agent, thus treating notifs as Toast, not Push?

Sure, Desktop Bridge would have been great if it didn't interfere with online status

Yuraconst commented 4 years ago

Well, that explains why it's been dropped, but it's kind of a sad deal. Also, on the chat channel of this project within Telg itself, I'd suggest switching the bot to digest mode if possible, because it gets messy otherwise.

MarcAnt01 commented 4 years ago

What bot are you talking about?

Yuraconst commented 4 years ago

the issue notification / cross-talk bot.

MarcAnt01 commented 4 years ago

the issue notification / cross-talk bot.

Still don't get what bot you're referring to

Yuraconst commented 4 years ago

the github bot (t.me/githubbot)

MarcAnt01 commented 4 years ago

the github bot (t.me/githubbot)

I am not in the Insiders group, but I suggest you not to use it to comment issues, since it is very buggy

Yuraconst commented 4 years ago

ok, got it...