UnigramDev / Unigram

Telegram for Windows
https://www.microsoft.com/store/apps/9n97zckpd60q
GNU General Public License v3.0
3.7k stars 432 forks source link

UI regression on replying message with touch pad #2662

Open Jack-Works opened 2 years ago

Jack-Works commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce

In this UI,

image

Swipe left use 2 fingers on the high precision touchpad on a message

Expected behavior

The message can be swiped left, and when the finger releases, it becomes the "reply" state.

image

In the newer version, this useful feature seems removed.

Version Info

Additional context Add any other context about the problem here.

makisukurisu commented 2 years ago

Additional note: horizontal scroll causes vertical scroll in chat list and chat window.

FrayxRulez commented 2 years ago

I'm using the same version of the app and I can't reproduce the issue. Additionally, there was no changes to this logic since October: https://github.com/UnigramDev/Unigram/commits/develop/Unigram/Unigram/Controls/Chats/ChatListViewItem.cs

makisukurisu commented 2 years ago

You can try to swipe between chats/contacts/calls/settings in Unigram.

Thanks for the report. P.S. ELAN 21.2.27.1 doesn't inform system about swipe actions, apparently. Or it does, but in such a way modern apps cannot understand.

You can try to see if SwipeControl works for your machine in WinUI 3 Controls Gallery, if it does this issue must be investigated further, if it doesn't - this is caused by driver your trackpad is using (if you don't have one - you might want to see if there is any for your machine and try with it)

Jack-Works commented 2 years ago

You can try to see if SwipeControl works for your machine in WinUI 3 Controls Gallery, if it does this issue must be investigated further

Yes, I can swipe from left to right and reveal the "accept" and the "flag" button in the SwipeView.

When I do the same action on one of the messages in the Unigram, it does not work.

I tried to swipe in the chat list and it works. Looks like it only fails in the chat UI.

caeslucio commented 2 years ago

I've using a Windows 10 touchscreen laptop Dell 15r 5537, and I'm unable to use swipe to reply on current version of Unigram, both Store (8.6.7182.0) and Direct (8.7.7352.0) versions.

caeslucio commented 2 years ago

On touchscreen I tried to swipe in the chat list and it works here too

caeslucio commented 2 years ago

But it working like in the chat UI, because when I swipe to right it shows the reply icon

lloydo3000 commented 2 years ago

I tried to swipe in the chat list and it works. Looks like it only fails in the chat UI.

Same for me

MarcAnt01 commented 2 years ago

@caeslucio @lloydo3000 this is not related, since here the user here is unable both to reply and forward the message with the gestures, while your issue seems to be the chats forwarding menu not loading, while gestures are working properly, please consider opening a separated ticket

lloydo3000 commented 2 years ago

Thank you but my issued is exactly as described in the ticket. Gestures work in other apps, but since a change in Unigram a few months ago, the do not work on messages in a chat (they do work swiping on the menus, as described above). The gestures don't work either on touchpads or on touchscreens. I have seen this on multiple computers now. I would love a fix as it was a great productivity booster.

Jack-Works commented 2 years ago

I just upgraded to Windows 11 22H2, and with Unigram 8.6 (7182) this problem no longer existed. Another of my PC is in Windows 10 21H2 Unigram 8.6 (7182), this problem still exists.

FrayxRulez commented 1 year ago

Yeah, late comment here. I believe that the regression was introduced by this commit and I didn't notice because there was a (undocumented) breaking change in Windows 11: https://github.com/UnigramDev/Unigram/commit/2af040b38be04a30be657914709313e7adce6269

FrayxRulez commented 1 year ago

Doesn't seem to be fixed actually