search

Unihedro / JavaBot

Java based chat bot that runs in Java room of Stack Overflow Chat.
Apache License 2.0
15 stars 4 forks source link

Help-Command fix #45

Closed Vogel612 closed 9 years ago

Vogel612 commented 9 years ago

Fixed a bug with the null names of listeners in the Collection returned by DefaultBot::getSubscriptions(), Slightly changed behavior of help-command to give a little more information.

Unihedro commented 9 years ago

Any specific reason for using if ("".equals(helpText.get())) instead of .isEmpty()? Other than that it looks fine to me, given that it's work - I can't test this until I'm at home.

Vogel612 commented 9 years ago

it works better with null values, which is idiotic by that point in code, since a null optional is actually empty and the if-condition then makes reaching that branch impossible