Uninett / Argus-frontend

Front-end application to the Argus alert aggregator backend
GNU General Public License v3.0
8 stars 10 forks source link

Support sorting/ordering #253

Open jorgenbele opened 3 years ago

jorgenbele commented 3 years ago

Currently we do a sort on the incidents, but this doesn't really do anything.

https://github.com/Uninett/Argus-frontend/blob/b18bcdbdfad3b3b1fe526e17bbcd750cd02d2140/src/components/incidenttable/IncidentTable.tsx#L196

lunkwill42 commented 3 years ago

This has been flagged as pretty important. I.e. when there is a large outage, multiple related incidents may be opened. Feedback from users is that in such a case, it is critical that the list of open incidents can be sorted by severity levels, so that the most critical incidents are listed first.

Currently, I assume incidents are only sorted in the order in which they were created.

The question is: Should the incident list be sortable either by:

  1. any column, as selected by the user
  2. Always sorted by level first, time last
  3. Severity level, if user has checked that column to be sorted, otherwise just by time, as before?

I would assume if the users are asked further, they would prefer option 1, but some feedback on scope of that implementation would be interesting.

hmpf commented 3 years ago

The way we currently have done paging we assume no changeable sort, always sort by timestamp, newest first. We chose the current type of paging because it is the only type that works real time with large datasets without losing/skipping rows. What you lose is changing the sort order.

lunkwill42 commented 3 years ago

IRL discussion:

podliashanyk commented 2 years ago
  • Now that we have the ability to filter by severity, we should ask the user: Is filtering sufficient to cover their use case?

Service Center finds filtering sufficient and regards sorting as "Nice to have". :)