Open hmpf opened 3 years ago
Blocked by #70. Modelling of severity values is needed.
Quoting @hmpf (#255)
Related question: should we change the field-names in the JSON-blob to python-style in anticipation of getting rid of the JSON-blob altogether in the backend, or should we wait?
When the new "level"-field is in, we should be able to filter on that as well, but that belongs in a separate issue.
A new, complete JSON-blob, with JavaScript-style key-names, would look like this:
{
"sourceSystemIds": [1,2,5],
"sourceSystemTypeIds": [3],
"tags": ["foo=bar"],
"open": true,
"acked": nil,
"stateful": nil,
}
Priority 1: Updating the API/schema
Priority 2: Make the notification filter obey the new filters
Another question: If the list of sources and source types are incompatible (source type says "nav" while source says "this zabbix host", what happens? If they are independent, then currently they will be ANDed together and the resulting list of incidents will be empty.
Blocked by #70. Modelling of severity values is needed.
We don't need to wait on severity to add support for openness/ackedness. We can do things in small, incremental steps.
Notes from design day:
Plan:
As Django 3.1 will introduce changes in the usage and handling of JSONField
, it seems sensible to complete #257 before tackling this.
Marking blocked until #257 is done.
Please also mind #136, which proposes API changes to the format of the tags submitted with an incident.
Tag values might need type-specific filtering:
Filter on (boolean) states
Filter on source type: similar to filtering on source
Filter on duration of an incident: has lasted more than/less than x minutes (#175)
Filter the incident list on the main page and not just for notifications (#170):