Uninett / Argus

Argus is an alert aggregator for monitoring systems
GNU General Public License v3.0
18 stars 13 forks source link

Link two first columns in Incident admin #798

Closed hmpf closed 5 months ago

hmpf commented 5 months ago

By default, the first displayed field is linked to the details page. The first field we show is source_incident_id which is optional. When it is not set there will be no link. Therefore, also link up the second field (start_time) so that we can always easily get to the details page.

johannaengland commented 5 months ago

Oh, good one, I just noticed that yesterday and was thinking about making an issue/fixing that!

johannaengland commented 5 months ago

If you agree with me on that, but don't want to bother with doing it, then let me know and I can work on it.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.61%. Comparing base (6488afa) to head (abdb02b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #798 +/- ## ======================================= Coverage 84.61% 84.61% ======================================= Files 75 75 Lines 3750 3750 ======================================= Hits 3173 3173 Misses 577 577 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 months ago

Test results

       7 files     574 suites   22m 1s :stopwatch:    462 tests    461 :heavy_check_mark: 1 :zzz: 0 :x: 3 234 runs  3 227 :heavy_check_mark: 7 :zzz: 0 :x:

Results for commit abdb02b4.

hmpf commented 5 months ago

I'll merge this and we can have a new issue about what to show in the list because it is a bit of a mess right now, especially on narrow screens. I'd want to move "description" farther left among other things.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud