Closed hmpf closed 1 month ago
Attention: Patch coverage is 94.11765%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 84.81%. Comparing base (
05d26f0
) to head (9187b71
). Report is 10 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
src/argus/site/utils.py | 94.11% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
7 files 616 suites 22m 55s :stopwatch: 488 tests 487 :heavy_check_mark: 1 :zzz: 0 :x: 3 416 runs 3 409 :heavy_check_mark: 7 :zzz: 0 :x:
Results for commit 9187b715.
:recycle: This comment has been updated with latest results.
Can't see anything wrong with the added functionality itself (except it seems to me that GNOC will still bypass all these hook-ins by writing their own settings file by hand?)
I've grown fond of it myself, much quicker adjusting settings by changing a json file that I cat(1)
into the environment variable than adjusting the settings file and urls.py when flipping between branches with different needs. Pretty good dev UX!
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Bonus: halt setup with a traceback if the JSON in EXTRA_APPS/OVERRIDING_APPS is buggy!
How to use: add a context processor in an app (for instance
argus_htmx.context_processors
in Uninett/argus-htmx-frontend#15) to the app, it's a list on the keycontext_processors
.