Uninett / Argus

Argus is an alert aggregator for monitoring systems
GNU General Public License v3.0
18 stars 12 forks source link

Move notificationprofile.Filter stuff to own place #812

Closed hmpf closed 1 day ago

hmpf commented 1 month ago

There are still some "XXX"-marked lines for methods that probably ought to move, but nothing in argus.incident imports the Filter-model or NotifcationProfile-model anymore.

Best reviewed commit by commit.

github-actions[bot] commented 1 month ago

Test results

       7 files     553 suites   21m 42s :stopwatch:    449 tests    448 :heavy_check_mark: 1 :zzz: 0 :x: 3 143 runs  3 136 :heavy_check_mark: 7 :zzz: 0 :x:

Results for commit 440ebf22.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.99191% with 26 lines in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (cdc23e5) to head (93dbbf8).

Files Patch % Lines
src/argus/compat.py 64.00% 9 Missing :warning:
src/argus/filter/filterwrapper.py 93.51% 7 Missing :warning:
src/argus/filter/validators.py 54.54% 5 Missing :warning:
src/argus/filter/filters.py 97.89% 2 Missing :warning:
src/argus/filter/V1/serializers.py 98.07% 1 Missing :warning:
src/argus/filter/checks.py 90.00% 1 Missing :warning:
src/argus/notificationprofile/checks.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #812 +/- ## ========================================== - Coverage 84.81% 84.36% -0.46% ========================================== Files 76 83 +7 Lines 3846 3926 +80 ========================================== + Hits 3262 3312 +50 - Misses 584 614 +30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud