search

Uninett / Howitz

1 stars 3 forks source link

[BUG]: Footer fetches itself in an endless loop #84

Closed podliashanyk closed 6 months ago

podliashanyk commented 6 months ago

This was because of a trigger set to on 'load' and swap method set to 'outerHTML'. This combination made it so that on each fetch footer was replaced completely aka loaded anew, so load trigger was activated and footer refetch itself again.

github-actions[bot] commented 6 months ago

Test results

  4 files    4 suites   7s :stopwatch: 14 tests 14 :heavy_check_mark: 0 :zzz: 0 :x: 56 runs  56 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 8f7544d3.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@5ca4757). Click here to learn what that means.

Files Patch % Lines
src/howitz/endpoints.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #84 +/- ## ======================================= Coverage ? 50.49% ======================================= Files ? 15 Lines ? 804 Branches ? 0 ======================================= Hits ? 406 Misses ? 398 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.