search

Uninett / mod_auth_mellon

An Apache module with a simple SAML 2.0 service provider
207 stars 182 forks source link

Diagnostics #133

Closed jdennis closed 7 years ago

jdennis commented 7 years ago

There are 5 commits in this branch to merge. Each of the first 3 commits are there to support the final diagnostics branch and can be applied without the final commit. The commits were done that way to factor out the actual diagnostic code from changes that were necessary to support the diagnostics effort. I don't normally merge pull requests on Github, I assume you can pull in each commit independently so they remain independent commits, but if not I'll cancel this pull request and split them out individually.

As per our email conversation I updated the diagnostics patch such that the 2 new Mellon configuration directives can be used with either a diagnostics build or a non-diagnostics build. In a non-diagnostics build a warning is emitted in the Apache error, here is an example:

[auth_mellon:warn] [pid 7528] MellonDiagnosticsEnable has no effect because Mellon was not compiled with diagnostics enabled, use ./configure --with-diagnostics at build time to turn this feature on.

jdennis commented 7 years ago

Updated this PR with discussed code changes (did a forced push of the diagnostics.1 branch).

jdennis commented 7 years ago

Force pushed a new patch set that address the issues raised in the review. Thank you for your time spent reviewing.

jdennis commented 7 years ago

Pushed fix with APLOG_NOTICE

olavmrk commented 7 years ago

Thsnk you very much! I have merged this pull request.

jdennis commented 7 years ago

Thank you Olav.