search

Uninett / mod_auth_mellon

An Apache module with a simple SAML 2.0 service provider
207 stars 182 forks source link

added some additional cli args for metadata script #182

Closed michaelrice closed 5 years ago

michaelrice commented 6 years ago

Added some additional cli args to the metadata creation sctipt. These allow you to set the following:

The metadata file it makes by default was also expanded to add a few common options used when setting up for use with OpenStack Keystone.

olavmrk commented 6 years ago

Hi,

unless I am missing something, I don't think this will work. I.e. what happens if some of the options are not passed into the script? I don't see any default values for many of the options, which makes them mandatory.

I think the options need to have reasonable default values. The parameters that are mandatory (I.e. entityID and base URL) should remain as normal parameters. It would also be nice if the script can be invoked in the same way it could previously, so that old documentation still works.

olavmrk commented 5 years ago

Closing this pull request as part of archiving this project. See the announcement for details:

https://github.com/Uninett/mod_auth_mellon/blob/info/README.md