Uninett / mod_auth_mellon

An Apache module with a simple SAML 2.0 service provider

207 stars 182 forks source link

Fix: size not written to error_log #213

Closed oss-aimoto closed 5 years ago

oss-aimoto commented 5 years ago

Description

If MellonCacheEntrySize is not enough, the error log will be written as follows:

[Mon Jul 29 04:23:09.574050 2019] [auth_mellon:error] [pid 9] apr_cache_entry_store_string() 
asked %zd available: %zd. It may be a good idea to increase MellonCacheEntrySize.

Analysis

ap_log_error format is incorrect.

        ap_log_error(APLOG_MARK, APLOG_ERR, 0, NULL,
                     "apr_cache_entry_store_string() asked %zd available: %zd. "
                     "It may be a good idea to increase MellonCacheEntrySize.",
                     str_len, am_cache_entry_pool_left(entry));

olavmrk commented 5 years ago

Closing this pull request as part of archiving this project. See the announcement for details:

https://github.com/Uninett/mod_auth_mellon/blob/info/README.md