Uninett / nav

Network Administration Visualized
GNU General Public License v3.0
175 stars 37 forks source link

Add OUI model #2896

Open stveit opened 2 months ago

stveit commented 2 months ago

Work towards #1483

Thoughts on strictness of the oui field? Figured setting max and min length makes sense since the OUI should always be 6 characters long.

Any other information that should be included in the model?

Wasnt sure where to put the model so i just put it in its own file for now

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.26%. Comparing base (a2be786) to head (187f7d3). Report is 50 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2896 +/- ## ========================================== + Coverage 60.21% 60.26% +0.05% ========================================== Files 601 603 +2 Lines 43981 44093 +112 ========================================== + Hits 26481 26574 +93 - Misses 17500 17519 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Test results

     12 files       12 suites   11m 41s :stopwatch: 3 324 tests 3 324 :heavy_check_mark: 0 :zzz: 0 :x: 9 447 runs  9 447 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 1b333b05.

:recycle: This comment has been updated with latest results.

stveit commented 2 months ago

Made some changes according to your suggestions