Uninett / nav

Network Administration Visualized
GNU General Public License v3.0
175 stars 37 forks source link

Make it possible to download a ZIP file containing QR codes of bulk selected netboxes/rooms #2899

Open johannaengland opened 1 month ago

johannaengland commented 1 month ago

The last step to #2586.

It does not currently offer the ZIP file to download. I was able to create the ZIP file and am able to access it in the frontend (which I've shown by setting the ZIP file as bytes as the source of the added anchor element), but I do not know how to make it possible for the user to download it from there.

Screenshots - before and after

Before:

Screenshot from 2024-05-16 13-04-24 Screenshot from 2024-05-16 13-04-41

After:

Screenshot from 2024-05-16 13-08-03 Screenshot from 2024-05-16 13-08-15

github-actions[bot] commented 1 month ago

Test results

     12 files       12 suites   11m 44s :stopwatch: 3 324 tests 3 324 :heavy_check_mark: 0 :zzz: 0 :x: 9 447 runs  9 447 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit d21e5163.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.60%. Comparing base (b8d6d52) to head (2be6e05).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2899 +/- ## ========================================== + Coverage 56.35% 56.60% +0.24% ========================================== Files 603 603 Lines 43862 43916 +54 Branches 48 48 ========================================== + Hits 24719 24859 +140 + Misses 19131 19045 -86 Partials 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CLAassistant commented 6 hours ago

CLA assistant check
All committers have signed the CLA.