search

Uninett / nav

Network Administration Visualized
GNU General Public License v3.0
181 stars 38 forks source link

Rename `snmptrapd` command line program to `navtrapd` #2926

Closed lunkwill42 closed 4 months ago

lunkwill42 commented 4 months ago

Fixes #2882

This really just renames the installed "binary", it does not change the internal module names or references otherwise.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.27%. Comparing base (f7c02e2) to head (e9d0ef7). Report is 12 commits behind head on 5.10.x.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 5.10.x #2926 +/- ## ======================================= Coverage 60.27% 60.27% ======================================= Files 602 602 Lines 44099 44099 ======================================= Hits 26580 26580 Misses 17519 17519 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

Test results

     12 files       12 suites   12m 2s :stopwatch: 3 326 tests 3 326 :heavy_check_mark: 0 :zzz: 0 :x: 9 453 runs  9 453 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit e9d0ef77.

lunkwill42 commented 4 months ago

Why not also rename the nav.bin.snmptrapd file itself? Partly renaming seems like something that could be confusing

Simply because it's more work (than a simple bugfix) :)