Closed johannaengland closed 1 day ago
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
β PYTHON | black | 992 | 0 | 12.77s | |
β PYTHON | ruff | 988 | 0 | 0.1s |
See detailed report in MegaLinter reports
ββββ9 filesββββββ9 suitesβββ8m 20s β±οΈ 2β143 testsβ2β143 β β0 π€β0 β 4β025 runsββ4β025 β β0 π€β0 β
Results for commit 2a3fe465.
:recycle: This comment has been updated with latest results.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 60.30%. Comparing base (
855819a
) to head (2a3fe46
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Discovered one problem: If you are in the settings for a dashboard that can be deleted (so the button is shown), then you change it to become the default dashboard, then the delete button is still there and can be clicked
Ooof, that means I have to look at the javascript code again :sweat_smile:
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Dependent on #3233. Another potential part of the fix for #3150.
This hides the "Delete dashboard" button for the default dashboard. Up for discussion if this is how we want to prevent the user from trying to delete the default dashboard.
But this is how it is done for the case where the current dashboard is the last dashboard.
Before:
After: