Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
3 stars 4 forks source link

Move SNMP session setup to Task initialization #151

Closed johannaengland closed 5 months ago

johannaengland commented 5 months ago

After @hmpf's review I decided it might actually be nicer to factor out this part of the PR #133.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 5 months ago

Test results

    3 files      3 suites   25s :stopwatch: 206 tests 206 :heavy_check_mark: 0 :zzz: 0 :x: 618 runs  616 :heavy_check_mark: 2 :zzz: 0 :x:

Results for commit 2f42c9be.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (77c10bf) 97.85% compared to head (2f42c9b) 97.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #151 +/- ## ========================================== - Coverage 97.85% 97.85% -0.01% ========================================== Files 31 31 Lines 2377 2370 -7 ========================================== - Hits 2326 2319 -7 Misses 51 51 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.