Ignore trailing garbage args on API commands

Uninett / zino

Zino 2.0 - Network state monitor for research networks

Apache License 2.0

3 stars 4 forks source link

Ignore trailing garbage args on API commands #162

Closed lunkwill42 closed 5 months ago

lunkwill42 commented 5 months ago

Apparently, legacy clients may attempt to send extra garbage arguments at the end of commands like the USER command, and Zino 1 was fine with this, while Zino 2 would respond with an error, causing the client to fail on login.

This changes the behavior of the legacy protocol implementation to allow, but ignoree and log extraneous command arguments.

github-actions[bot] commented 5 months ago

Test results

    3 files     3 suites 26s :stopwatch: 245 tests 245 :heavy_check_mark: 0 :zzz: 0 :x: 735 runs 733 :heavy_check_mark: 2 :zzz: 0 :x:

Results for commit 20d9ab7d.

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud