Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
3 stars 4 forks source link

Rename BGP event attributes to follow Zino1 protocol #172

Closed johannaengland closed 3 months ago

johannaengland commented 5 months ago

I used this as an opportunity to also fix #171, which made the rest of the task much easier.

While I was working on that an comparing between Zino1 and my code I realized that I forgot the part that admin up will only update existing event, not create new events. That is also added here.

This difference between how BGP events look in Zino1 and Zino2 was so nicely pointed out to me by @runborg.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 5 months ago

Test results

    3 files      3 suites   31s :stopwatch: 289 tests 289 :heavy_check_mark: 0 :zzz: 0 :x: 867 runs  865 :heavy_check_mark: 2 :zzz: 0 :x:

Results for commit a598fee1.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ef47c1c) 98.80% compared to head (a598fee) 98.82%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #172 +/- ## ========================================== + Coverage 98.80% 98.82% +0.02% ========================================== Files 40 40 Lines 5432 5422 -10 ========================================== - Hits 5367 5358 -9 + Misses 65 64 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.