Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
3 stars 4 forks source link

Do not include event ids of closed events in CASEIDS command #192

Closed johannaengland closed 3 months ago

johannaengland commented 3 months ago

Closes #187.

Needs to be first checked if this is the same behavior as with Zino 1.0.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.82%. Comparing base (c487a05) to head (dd73a51).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #192 +/- ## ======================================= Coverage 98.82% 98.82% ======================================= Files 40 40 Lines 5421 5423 +2 ======================================= + Hits 5357 5359 +2 Misses 64 64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Test results

    3 files      3 suites   34s :stopwatch: 290 tests 290 :heavy_check_mark: 0 :zzz: 0 :x: 870 runs  868 :heavy_check_mark: 2 :zzz: 0 :x:

Results for commit dd73a514.

:recycle: This comment has been updated with latest results.

lunkwill42 commented 3 months ago

Needs to be first checked if this is the same behavior as with Zino 1.0.

Seems consistent, according to my tests. The main difference is that Zino 1 doesn't filter the events in the implementation of CASEIDS, rather it only indexes non-closed events.

However, it doesn't really matter how this works internally in Zino 2 as long as CASEIDS doesn't list closed events, and closed events cannot be reopened.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud