Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
3 stars 5 forks source link

BFD: missing attribute neigh_rdns #199

Closed runborg closed 3 months ago

runborg commented 6 months ago

The attribute neigh_rdns should include "reverse dns" information of the BFD neighbor. (reverse dns of the address in the bfdaddr field i think)

the zino1 server is not consistent on this field on all types containing ipv4/ipv6 neighbor info, but this could certanly also be done on eg. BGP alarms.

This field is not critical for eg. curitz to function at this state

lunkwill42 commented 3 months ago

Question: The original codebase seems to call the field Neigh-rDNS, not neigh_rdns. Does the difference matter to any existing clients?

runborg commented 3 months ago

Ah, it might be that i've miss-spelled it.. it is used both in x11-ritz and in curitz, it might be that zinolib / curitz translates - to _ in the attributes to be allowed used as properties directly.

runborg commented 3 months ago

yea, it is rewritten.. zino 1 zino 0.10

runborg commented 3 months ago

so as to also support the original X11 client it needs to have its original name: Neigh-rDNS

stveit commented 3 months ago

Naming in regards to hyphens and case sensitivity is now handled in #281