Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
3 stars 5 forks source link

Create initial BFD state only when a real BFD state shows up #214

Closed stveit closed 5 months ago

stveit commented 5 months ago

Fixes #197

Makes initial event creation more similar to how original Zino does it. instead of creating a placeholder noSession state, wait to create a state until something actually shows up. Then, if a state is created for the first time and nothing previous to compare against, create event if state is not up.

Zino1 source: https://gitlab.sikt.no/verktoy/zino/-/blob/master/zino/bfd.tcl?ref_type=heads#L242

This should also solve the issue of missing fields in #197

github-actions[bot] commented 5 months ago

Test results

    3 files      3 suites   48s :stopwatch: 315 tests 315 :heavy_check_mark: 0 :zzz: 0 :x: 945 runs  943 :heavy_check_mark: 2 :zzz: 0 :x:

Results for commit 2565305f.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.97%. Comparing base (976646d) to head (2565305).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #214 +/- ## ======================================= Coverage 98.97% 98.97% ======================================= Files 47 47 Lines 6529 6532 +3 ======================================= + Hits 6462 6465 +3 Misses 67 67 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud