Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
3 stars 5 forks source link

Fix two stupid bugs in `LinkStateTask.poll_single_interface` #240

Closed lunkwill42 closed 3 months ago

lunkwill42 commented 4 months ago

This fixes problems with timeouts and getting interface data for interfaces with ifindex=1. See commit comments for details.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 4 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 0 0.53s
✅ PYTHON isort 2 0 0.22s
✅ PYTHON ruff 2 0 0.01s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

github-actions[bot] commented 4 months ago

Test results

  3 files    3 suites   50s :stopwatch: 322 tests 322 :white_check_mark: 0 :zzz: 0 :x: 966 runs  964 :white_check_mark: 2 :zzz: 0 :x:

Results for commit 3bd7e331.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.98%. Comparing base (ee3412f) to head (3bd7e33). Report is 9 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #240 +/- ## ======================================= Coverage 98.98% 98.98% ======================================= Files 50 50 Lines 6566 6570 +4 ======================================= + Hits 6499 6503 +4 Misses 67 67 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.