Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
3 stars 5 forks source link

Schedule single interface poll jobs when link trap changes state #241

Closed lunkwill42 closed 3 months ago

lunkwill42 commented 4 months ago

Continued implementation of #232

Depends on #233 to be merged first.

github-actions[bot] commented 4 months ago

πŸ¦™ MegaLinter status: βœ… SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
βœ… PYTHON black 2 0 0.54s
βœ… PYTHON isort 2 0 0.21s
βœ… PYTHON ruff 2 0 0.01s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

github-actions[bot] commented 4 months ago

Test results

β€‡β€ˆβ€‡β€‡3 filesβ€„β€ƒβ€‡β€ˆβ€‡β€‡3 suites   54s :stopwatch: β€‡β€ˆ404 testsβ€ƒβ€‡β€ˆ404 :white_check_mark: 0 :zzz: 0 :x: 1β€ˆ212 runsβ€Šβ€ƒ1β€ˆ210 :white_check_mark: 2 :zzz: 0 :x:

Results for commit ef688f8f.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.88%. Comparing base (58bf6f8) to head (ef688f8).

Files Patch % Lines
src/zino/trapobservers/link_traps.py 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #241 +/- ## ========================================== - Coverage 98.89% 98.88% -0.01% ========================================== Files 51 51 Lines 6875 6882 +7 ========================================== + Hits 6799 6805 +6 - Misses 76 77 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lunkwill42 commented 3 months ago

See, this is the problem with dependent PRs, @stveit - most of your comments are actually directed towards commits that really came from a PR you've already approved :)

I do agree there's a lot that can be cleaned up overall, but I'm trying to stick as close as possible to the original before any potential refactors.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud