Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
3 stars 5 forks source link

Add flapping detection algorithm to link traps #244

Closed lunkwill42 closed 3 months ago

lunkwill42 commented 3 months ago

Incomplete implementation of flapping detection algorithms for link traps.

This closes #144 (and completes #232)

This builds on #241 and is dependent on that being merged first, keeping in Draft mode until then.

lunkwill42 commented 3 months ago

The original code has an impressive amount of redundancies when it comes to event generation. I hope to factor those out once I'm closing in on feature parity.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 98.02956% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.92%. Comparing base (ef688f8) to head (eed192d).

Files Patch % Lines
src/zino/trapobservers/link_traps.py 92.98% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/link-traps-reschedule #244 +/- ## ================================================================= + Coverage 98.88% 98.92% +0.04% ================================================================= Files 51 52 +1 Lines 6882 7056 +174 ================================================================= + Hits 6805 6980 +175 + Misses 77 76 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
298 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud