Closed johannaengland closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.99%. Comparing base (
b1ffc1c
) to head (b02b21f
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fun bug!
Question: what happens if we go from N to 0 alarms?
* Is there another message?
Yes, a log is added to the event that says exactly that.
* Is the event closed?
No, as in Zino1, events are never closed automatically, that has to happen manually.
* Is the event closed?
No, as in Zino1, events are never closed automatically, that has to happen manually.
So if it goes back from 0 to N the event is reused?
Now it makes me wonder how clients show this. 0 is a good thing and should be shown different from bigger than 0. I guess we can test when we have a way to fake an event =)
So if it goes back from 0 to N the event is reused?
Yes, but only if the event has not been closed by then.
Now it makes me wonder how clients show this. 0 is a good thing and should be shown different from bigger than 0. I guess we can test when we have a way to fake an event =)
I would assume that clients show it just like any other event. But feel free to post that as an issue in Howitz
Closes #213.
We got the log message "yellow alarms went from None to 1", because on the first Juniper alarm we create an event, which does not have an alarm count yet.