Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
3 stars 5 forks source link

Catch new SNMP errors in juniper alarm task #275

Closed johannaengland closed 3 months ago

johannaengland commented 3 months ago

Scope and purpose

Fixes #212.

This amends the changes made in #231 according to the new SNMP errors introduced/handled in #262. This should finally lead to error being correctly handled and only things being logged if the device has an alarm count of an invalid type (but not none).

Contributor Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.04%. Comparing base (5d77dc6) to head (a6f6a89).

:exclamation: Current head a6f6a89 differs from pull request most recent head 5670e2b

Please upload reports for the commit 5670e2b to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #275 +/- ## ========================================== + Coverage 98.88% 99.04% +0.16% ========================================== Files 51 50 -1 Lines 6876 6776 -100 ========================================== - Hits 6799 6711 -88 + Misses 77 65 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.