Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
4 stars 5 forks source link

unify methods of rewriting event properties to match zino 1 protocol. #338

Open runborg opened 3 months ago

runborg commented 3 months ago

There are now two ways that event property-names are modified to match the zino 1 protocol names. the first one is a catch-all rewrite of underscore to dashes: https://github.com/Uninett/zino/commit/7caf8807f2923a013251ca3dbb2b11406b011281#diff-5eef89ad67750f4ac6ef25ea411553bf2bc5dab2d901020b7526ab52b774bf3b

and the new one is using aliasses in pydantic to create custom names as done here: https://github.com/Uninett/zino/pull/335

as there is also some case-sensitive property-names the first implementation does not fit all modifications, that should be removed and add pydantic aliasses to all properties that need a rewrite instead.

as for now it seems to be these elements needing to be rewritten to pydantic aliasses:

BGP:

Alarm:

johannaengland commented 3 months ago

This issue merits a meeting about all the event/pm attribute names, to generally having better/more descriptive names and then adding the Zino1 names as alias.

lunkwill42 commented 3 months ago

This is related to #281