Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
4 stars 5 forks source link

Use default interval from pollfile to stagger new jobs #339

Closed johannaengland closed 3 months ago

johannaengland commented 3 months ago

Scope and purpose

Fixes #337.

Changed the way that read_polldevs work to make it easier to return the PollDevices and the default values. I was considering splitting the function in two: One to read the defaults and one to read the rest - the poll devices, but decided for this method, since it is simpler changes.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is. More information about contributing to Zino can be found in the README.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.20%. Comparing base (70b1a57) to head (a3300ec).

Files Patch % Lines
src/zino/getuptime.py 66.67% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #339 +/- ## ======================================= Coverage 98.20% 98.20% ======================================= Files 64 64 Lines 7926 7930 +4 ======================================= + Hits 7783 7787 +4 Misses 143 143 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud